Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android pipeline timeout declaration #2360

Merged
merged 10 commits into from
Oct 22, 2024
Merged

Conversation

jekloudaMSFT
Copy link
Contributor

For more information about how to contribute to this repo, visit this page.

Description

The timeout on the install emulator task in the Android pipeline wasn't working because it wasn't declared in the right spot in the yaml. This should fix it.

If this Pull Request should close/resolve any issues when merged, use the special syntax for that here.

Main changes in the PR:

  1. Move timeout declaration to top level of task declaration

Validation

Validation performed:

  1. Android pipeline continues to run, there's no way to force a emulator timeout as far as I know, so I'll keep an eye out to see if this fixes it.

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

No, pipeline changes only

End-to-end tests added:

No

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

No, pipeline changes only

@jekloudaMSFT jekloudaMSFT requested a review from a team as a code owner June 14, 2024 22:12
Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@TrevorJoelHarris TrevorJoelHarris enabled auto-merge (squash) July 1, 2024 18:58
@TrevorJoelHarris TrevorJoelHarris self-assigned this Jul 1, 2024
@jekloudaMSFT jekloudaMSFT enabled auto-merge (squash) October 21, 2024 18:02
@jekloudaMSFT jekloudaMSFT merged commit 73d0f80 into main Oct 22, 2024
28 checks passed
@jekloudaMSFT jekloudaMSFT deleted the jeklouda/androidTimeout branch October 22, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants